Jonathon Marolf
Jonathon Marolf
would be helpful to know if there is any better perf in the latest (unrelesed) version. ``` dotnet tool install -g dotnet-format --version 5.0.135301 --add-source https://dotnet.myget.org/F/format/api/v3/index.json ``` in general formatting...
Yep this should be fast. The second we spend discovering files is unnecessary. that at least gets us to 500ms
No, I'll likely use your project as the basis for some perf validation.
yeah. I'll need to look here but I think a reasonable place to start at is that we should be able to get single file formats under 500ms
@AdamSpeight2008 I believe you closed that PR, do you still want to work on this?
> all refactorings were safe without thought was to whether they change behavior This is the thinking of every developer using our tools that I have ever encountered. While refactoring...
Long term, yes. Talked to the fantomas maintainers a while back and they where amenable to use including/calling into fantomas for F# projects. Would be willing to accept a community...
I believe this is coming from MSBuildWorkspace @DustinCampbell ?
> I would guess this is happening with multi-targeted projects? That is where I observed it happening (in roslyn anyway). For the purposes of `dotnet-format` do you think it is...
I think we should not still log this in verbose mode, but not tell the user that the project loaded with warnings if this is the only warning kind encountered....