Jonathon Marolf

Results 110 comments of Jonathon Marolf

@tmat can you point me to the targests in arcade that do sourcelink? I think the easiest way forward is to copy those

> Is there a plan to move PS to Arcade? No arcade is all about shipping as part of the .NET Core SDK and has very little support for VSIXes...

> That's not quite true. We use Arcade for Interactive Window repo as well. Does it build out of dnceng internal like arcade recommends?

Alright, there is no easy path forward. The existing repotoolset targets set out-of-date properties that interfere with sourcelink. We either need to move off of repotoolset entirely or move to...

@davkean pull down the branch from https://github.com/dotnet/project-system/pull/5620 you will get this build error ``` C:\Users\vsagent\.nuget\packages\roslyntools.repotoolset\1.0.0-beta-62705-01\tools\RepositoryInfo.targets(65,5): error : SourceRoot contains duplicate items 'F:\workspace\_work\1\s\' with conflicting metadata 'SourceControl': 'git' and 'Git' [F:\workspace\_work\1\s\setup\ProjectSystemSetup\ProjectSystemSetup.csproj]...

I suppose some careful over-ridding of targets could make things work. I will freely admit that is beyond me. Look forward to seeing the solution

I believe the problem is we never set up a process to track publishing them regularly after balaji left.

> I have serious concerns about this, in particular for any code that touches the compiler leg. Yes, the bootstrap build is slow. The bugs it catches are the types...

@jaredpar can I get another review pass now that I've implemented this running the bootstrap build if there are compiler changes?

verified these changes in https://github.com/dotnet/roslyn/pull/63368