Joshua Marantz comments

Results 291 comments of


                                            Joshua Marantz

json log with sort_properties prints decimals for all numbers

Oh this might be solved by https://github.com/envoyproxy/envoy/pull/35545 -- @wbpcode WDYT?

json log with sort_properties prints decimals for all numbers

sure but are you certain you are trying with #35545 in your build? Or are you using a release binary that might not include it?

json log with sort_properties prints decimals for all numbers

I think maybe an earlier version of #35545 would have fixed this by inheriting the behavior from JsonStreamer: https://github.com/envoyproxy/envoy/blob/520442a7e2b676ee7c710fcea26ae904be6abc65/source/common/json/json_streamer.h#L389 See the overrides for addNumber with integer args. However I think...

proxy_protocol_filter: Add field `stat_prefix` to the filter configuration

one documentation nit remains.

Ext proc http basic functionality support

Needs main merge. I'm having a little trouble following whether we are not blocked on reviewers or on author activity. /wait

Enhance ext_proc filter to support MXN streaming

I agree; I think internal buffering or MxN complicates the model and how to reason about it.

Enhance ext_proc filter to support MXN streaming

/wait

Enhance ext_proc filter to support MXN streaming

/wait (for #36999)

Add functionality to set downstream socket option from L7 filter callback

After existing reviewers approve we can assign a maintainer.

json: new exception free sanitize method

So if I have two different same-length strings that are completey invalid utf-8 then this impl will alias them together?