Joshua Marantz
Joshua Marantz
RE tidy not finding spdlog.h: I believe I've seen this before. The cause is BUILD files that don't fully list required dependencies. Normal compiles work because of transitive dependencies. But,...
/wait (Boteng has unresolved comments)
Please take a look at https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md and in particular the paragraph about force-pushing: > Once your PR is under review, please do not rebase it. If you rebase, you will...
Just to clarify; is the plan to make this an extension? I would assume wouldn't want to add this dependency in core?
I don't know the details of how this should work, but I'm guessing that we wouldn't want enabling auth to imply enabling bcrypt; we'd want to use a separate extension...
@yanavlasov FYI IMO this should be in 'contrib' or maybe an 'extension' if a suitable maintainer-sponser can be found, but should not be in 'core'. E.g. we probably don't want...
Yes. When you are doing a massive code move like this I'd prefer that no other changes at all be made. Just move the code and drop the .cc file...
Looks great. Can you add the admin stats benchmark before/after for this PR? That will establish a baseline for other changes you might want to make (e.g. using visit pattern)...
THe benchmark is the inlined version? Can you show it against the current version?