envoy
envoy copied to clipboard
Add functionality to set downstream socket option from L7 filter callback
Commit Message: Add functionality to set downstream socket option from L7 filter callback. Additional Description: Risk Level: Low (Optional feature) Testing: Unit tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: No
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist
CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123
/retest
/retest
/assign @paul-r-gall
Looks like the coverage is sorted out, so removing myself.
After existing reviewers approve we can assign a maintainer.
@abeyad wdyt from an API view?
Assigning to Greg for non-google senior maintainer + socket expertise. Greg, if you are overloaded, please let me know and I can assign to someone else.
/assign @ggreenway
This should be ready for a final pass
I did the following:
- Added a test case for failing to set the socket option.
- Ensured a socket option is only added to a socket if it set successfully.
CI is failing. Can you check why? Might need a main merge.
/wait-any
@ggreenway && @paul-r-gall I needed to bump up the test coverage to get the checks to pass. This should be good to go.