envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Add functionality to set downstream socket option from L7 filter callback

Open jtlisi opened this issue 7 months ago • 12 comments
trafficstars

Commit Message: Add functionality to set downstream socket option from L7 filter callback. Additional Description: Risk Level: Low (Optional feature) Testing: Unit tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: No

jtlisi avatar Apr 22 '25 14:04 jtlisi

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/39200 was opened by jtlisi.

see: more, trace.

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh). envoyproxy/coverage-shephards assignee is @RyanTheOptimist CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc). CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @abeyad CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/). CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @mattklein123

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/39200 was synchronize by jtlisi.

see: more, trace.

/retest

jtlisi avatar Apr 25 '25 17:04 jtlisi

/retest

jtlisi avatar Apr 29 '25 12:04 jtlisi

/assign @paul-r-gall

jtlisi avatar Apr 29 '25 12:04 jtlisi

Looks like the coverage is sorted out, so removing myself.

RyanTheOptimist avatar May 02 '25 22:05 RyanTheOptimist

After existing reviewers approve we can assign a maintainer.

jmarantz avatar May 09 '25 15:05 jmarantz

@abeyad wdyt from an API view?

paul-r-gall avatar May 15 '25 19:05 paul-r-gall

Assigning to Greg for non-google senior maintainer + socket expertise. Greg, if you are overloaded, please let me know and I can assign to someone else.

/assign @ggreenway

paul-r-gall avatar May 20 '25 15:05 paul-r-gall

This should be ready for a final pass

I did the following:

  • Added a test case for failing to set the socket option.
  • Ensured a socket option is only added to a socket if it set successfully.

jtlisi avatar Jun 05 '25 00:06 jtlisi

CI is failing. Can you check why? Might need a main merge.

/wait-any

ggreenway avatar Jun 11 '25 15:06 ggreenway

@ggreenway && @paul-r-gall I needed to bump up the test coverage to get the checks to pass. This should be good to go.

jtlisi avatar Jun 16 '25 17:06 jtlisi