Joshua Marantz
Joshua Marantz
Yes I can :) I can expect that the serializer generates a byte sequence that's legal json, that deserializes into the original bytes. That's what the current one does. However,...
I don't expect anything, but this is a regression to current behavior. I said it's OK we just have to decide we will lose info in that case, and document...
I have a new idea. See source/common/protobuf/yaml_utility.cc, function utf8CoerceToStructurallyValid. Based on the logic in there we can write a scanner to see if utf8 is structurally valid. If it's not,...
Yes I think so. I didn't see it has part of the protobuf library, but I do see it in ./external/com_google_protobuf/third_party/utf8_range/_virtual_includes/utf8_validity/utf8_validity.h. In source/common/protobuf/yaml_utility.cc it just includes "utf8_validity.h" so I think...
Good point about sharing keywords. And the modern way of using a constexpr string view avoids the annoying lazy string singleton. But I suggest you move these constants to their...
@botengyao anything blocking moving forward with a review?
Is this ready for maintainer review?