Joshua Marantz

Results 291 comments of Joshua Marantz

@hanxiaop please do not force-push; it makes reviewing harder. Please read https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#submitting-a-pr especially bullet 14. Thank you!

looks like formatting is still broken. /wait

Thanks for the doc; I feel that a lot of the decisions made in the non-evicting version need to be highly informed about how you will do eviction. I'll try...

Thanks I read through the doc and left comments and would like to iterate on that a bit before code. There really are a lot of options in front of...

I'm still hoping to converge fully on the doc before diving into the code :) /wait

I thought I'd add Todd to the review for caching semantics. Todd -- I shared the doc with you also. You might want to look at that first.