envoy
envoy copied to clipboard
build: Fix call to std::min for newer compiler
Signed-off-by: Andrew Duerig [email protected]
std::min needs to explicitly have the same types, build errors with this:
test/common/buffer/buffer_fuzz.cc:123:26: error: no matching function for call to 'min'
auto copy_length = std::min((length - size_copied), slices[num_slices_copied].len_);
^~~~~~~~
/Applications/Xcode_13.4.0_fb.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/c++/v1/__algorithm/min.h:39:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long long' vs. 'unsigned long')
min(const _Tp& __a, const _Tp& __b)
Hi @aduerig, welcome and thank you for your contribution.
We will try to review your Pull Request as quickly as possible.
In the meantime, please take a look at the contribution guidelines if you have not done so already.
/wait
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!