Joshua Marantz comments

Results 291 comments of


                                            Joshua Marantz

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

/retest

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

@zirain FYI

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

I think if we need to defend Prom et al from duplicate tags we should keep a set during tag extraction. It is a bit performance-sensitive so I'd prefer not...

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

I've thought of a way to add duplicate removals that shouldn't be too expensive in terms of CPU. It would be great to hear from Prometheus experts (@ggreenway) about whether...

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

Thanks -- in that case I think the existing state risks miss-populating Prom in one case with two ways to populate HTTP_CONN_MANAGER_PREFIX and also needs to be fixed. I'll revert...

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

Sounds good; thanks Greg.

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

@ggreenway can you take a look at the approach? It needs a doc update and another test or two, but I wanted to see if you think this is the...

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

/retest

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

/retest

stats: Eliminate duplicate tag-name check to allow multiple regexes to populate the same tag name.

@adisuissa can you do an API stamp? The proto change is just clarifying ambiguous behavior with an edited comment.