Joshua Marantz

RE pointless tests: I think in general we want unit tests for classes in addition to the mid-level tests that show them in context. It's much easier to hit the...

Yes! Doc for ModPagespeedRequestOptionOverride is here: https://www.modpagespeed.com/doc/experiment#restrict-request-options On Sun, Sep 4, 2022 at 3:38 PM Tomas ***@***.***> wrote: > I would like pagespeed to remain on but would like to...

TBH I had not even heard of the envoy metrics service grpc endpoint. Is it possible that @lizan knows who owns this?

@marcosrmendezthd as you are motivated to see this fixed, would you like to take a run at it yourself? :)

assigning to Matt to first validate whether this should be an 'extension' or should be in 'contrib'. Also you need to fix format before CI can really run. /wait

@RyanTheOptimist are you also going to review this as a maintainer or should I assign someone else?

/assign-from @envoyproxy/first-pass-reviewers

@phlax can you review this? Thanks!

seems plausible. Prometheus stats allocate a very large amount of temp storage so it's not surprising it stresses the memory profiler.

Were you triggering the overload manager?