Jens Kristian Villadsen

Results 225 comments of Jens Kristian Villadsen

Spotless: https://github.com/diffplug/spotless Errorproine: https://github.com/google/error-prone

Sure ... I can make a PR to the base getting the `additionalResourceFolders` added the `PackageInstallationSpec`.

@jamesagnew whats your take on the refactored version of the `PostConstruct` I've done here in https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-0f42a12718125be49d417ad9c402f5f2cecddfb7cb0ecfde364ad09132fa2a99R21 as mentioned in https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/758

and btw - the same thing I did on https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-cca286d85a1c14aea8b529430ecd47aa4a803b53f4c7816deb7d602bd2af3268R11 can be done for a loooooong range of interceptor logic currently handled in the already way-too-big https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/792f520f629004504f30f88a96d1f5a6e584105b/src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java#L262 method (I'm not...

@jamesagnew I'll move the additional sources logic once its been merged in here - acceptable for you? Then we can merge this into https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/785 and remove it from the starter...

@jamesagnew / @dotasek - I've isolated the feature set now into https://github.com/hapifhir/hapi-fhir/pull/6802. Let me know if thats the feature set you had in mind, before I start writing tests and...

@dotasek once 8.4 is out the door this should be good to go.

Which would be after https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/842

This is not really a hapi-fhir-jpaserver-starter question - thats a general question on general matters.