hapi-fhir-jpaserver-starter icon indicating copy to clipboard operation
hapi-fhir-jpaserver-starter copied to clipboard

Consider adding spotless and error prone to github actions

Open jkiddo opened this issue 1 year ago • 4 comments

Should we consider adding spotless and/or errorprone to the github actions?

jkiddo avatar Oct 04 '24 09:10 jkiddo

Can you explain what that means?

joofio avatar Oct 04 '24 09:10 joofio

Spotless: https://github.com/diffplug/spotless Errorproine: https://github.com/google/error-prone

jkiddo avatar Oct 04 '24 10:10 jkiddo

github action or precommit hook? (or both?)

joofio avatar Oct 04 '24 14:10 joofio

HAPI itself uses spotless checks both as action and pre-commit, so adopting that seems entirely appropriate.

Actually, I haven't seen a spotless complaint from my HAPI git command line lately. Only checkstyle failures in the PR checks. I think I will go check if spotless is working for pre-commits...

I'll bring up error prone with some of the dev team. It's present in the codebase, but doesn't seem to be actively checked by anything.

dotasek avatar Oct 08 '24 16:10 dotasek