Jens Kristian Villadsen

Results 225 comments of Jens Kristian Villadsen

@codeforgreen can I persuade you to have a look at this?

An issue I discovered in the starter project using the IG installer functionality. If you install multiple IGs with overlapping resources then the order of installing suddenly starts to play...

@codeforgreen does the above provide the needed clarity?

@dotasek the error will be thrown in https://github.com/hapifhir/hapi-fhir/blob/8676cf2045375ee37d33f1978c6629fd92cd272a/hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/JpaResourceDaoCodeSystem.java#L252 I've added this test here https://github.com/hapifhir/hapi-fhir/pull/6291/files#diff-aa258240972be5bb70e69c9bb6ff0a8cd9ea9a93815c0d1e79e4cf446986f789R273 that might better explain and reproduce it.

I'm a bit uncertain on what the test should be on https://github.com/hapifhir/hapi-fhir/pull/6291/files#diff-aa258240972be5bb70e69c9bb6ff0a8cd9ea9a93815c0d1e79e4cf446986f789R285 - as the current expected behaviour is a bit dangerous, IMHO, as only parts of the IG being...

@dotasek here's the test that shows the issue - or not? It utterly depends on what expected behaviour is when you install different packages that by coincidence have same id...

Could a way forward be to explicitly have a config option to either enable or disable index jobs to run automatically? Problem then becomes to choose a sane default. If...

@fil512 based on git history I'd say one is in your direction :)