hapi-fhir-jpaserver-starter icon indicating copy to clipboard operation
hapi-fhir-jpaserver-starter copied to clipboard

Feat/extra resource loading from npm

Open jkiddo opened this issue 9 months ago • 12 comments

This feature is backwards compatible and introduces the option to load e.g. example packages from IG's based on configuration

jkiddo avatar Feb 23 '25 15:02 jkiddo

This functionality would probably make sense to just roll into the base PackageInstallationSpec. I'd rather not have this project implementing novel features not actually found in the base project, that's hard for support.

jamesagnew avatar Feb 23 '25 22:02 jamesagnew

Sure ... I can make a PR to the base getting the additionalResourceFolders added the PackageInstallationSpec.

jkiddo avatar Feb 24 '25 20:02 jkiddo

@jamesagnew whats your take on the refactored version of the PostConstruct I've done here in https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-0f42a12718125be49d417ad9c402f5f2cecddfb7cb0ecfde364ad09132fa2a99R21 as mentioned in https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/758

jkiddo avatar Feb 24 '25 20:02 jkiddo

and btw - the same thing I did on https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-cca286d85a1c14aea8b529430ecd47aa4a803b53f4c7816deb7d602bd2af3268R11 can be done for a loooooong range of interceptor logic currently handled in the already way-too-big https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/792f520f629004504f30f88a96d1f5a6e584105b/src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java#L262 method (I'm not pointing fingers here as I most likely authored a lot of it myself).

jkiddo avatar Feb 24 '25 20:02 jkiddo

@jamesagnew I'll move the additional sources logic once its been merged in here - acceptable for you? Then we can merge this into https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/785 and remove it from the starter as soon as it can be resolved from a snapshot in core.

jkiddo avatar Feb 27 '25 10:02 jkiddo

@jamesagnew / @dotasek - I've isolated the feature set now into https://github.com/hapifhir/hapi-fhir/pull/6802. Let me know if thats the feature set you had in mind, before I start writing tests and all.

jkiddo avatar Mar 14 '25 20:03 jkiddo

Formatting check succeeded!

robogary avatar May 07 '25 18:05 robogary

Formatting check succeeded!

robogary avatar May 25 '25 09:05 robogary

Formatting check succeeded!

robogary avatar May 26 '25 07:05 robogary

Formatting check succeeded!

robogary avatar Jun 05 '25 20:06 robogary

Formatting check succeeded!

robogary avatar Jun 05 '25 21:06 robogary

@dotasek once 8.4 is out the door this should be good to go.

jkiddo avatar Jun 05 '25 21:06 jkiddo

Which would be after https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/842

jkiddo avatar Jul 11 '25 21:07 jkiddo

This Pull Request has failed the formatting check

Please run mvn spotless:apply or mvn clean install -DskipTests to fix the formatting issues.

You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling pre-commit install --hook-type pre-push. This will cause formatting to run automatically whenever you push.

robogary avatar Aug 25 '25 14:08 robogary

Formatting check succeeded!

robogary avatar Aug 25 '25 14:08 robogary

This Pull Request has failed the formatting check

Please run mvn spotless:apply or mvn clean install -DskipTests to fix the formatting issues.

You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling pre-commit install --hook-type pre-push. This will cause formatting to run automatically whenever you push.

robogary avatar Aug 25 '25 14:08 robogary

This Pull Request has failed the formatting check

Please run mvn spotless:apply or mvn clean install -DskipTests to fix the formatting issues.

You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling pre-commit install --hook-type pre-push. This will cause formatting to run automatically whenever you push.

robogary avatar Aug 25 '25 14:08 robogary

Formatting check succeeded!

robogary avatar Aug 25 '25 14:08 robogary

Formatting check succeeded!

robogary avatar Aug 25 '25 14:08 robogary

Formatting check succeeded!

robogary avatar Aug 25 '25 17:08 robogary