Jithin Emmanuel

Results 53 comments of Jithin Emmanuel

This is also related to https://github.com/screwdriver-cd/screwdriver/issues/1208 When making model changes we should keep both features in mind

Adding retry options under `retry` object makes sense.

Sounds like a customer for the preferences API https://github.com/screwdriver-cd/models/pull/475

This setting should be a global one, user shouldn't have to go to each Pipeline to update preference.

is that important ? for no jobs to start, we should probably look at alternatives to let users know a webhook activity didn't start an event

Looks like edit is not working and is creating new comments.

@dwighthubbard looks like this is a known issue

> #1 should be solved with the above PR. Not sure if #2 is solved yet. 2. won't be solved by the above PR, it should be handled in `.done`...

Launch to always exit 0 change was introduced in [this PR](https://github.com/screwdriver-cd/launcher/commit/57f1c2365b1e78a4ee1f48e26e3528b9fd4aeb0f) many years ago. But we seem to have overused it by taking the same logic even before a build...