screwdriver icon indicating copy to clipboard operation
screwdriver copied to clipboard

UI is persisting error message in pipeline options page

Open jithine opened this issue 8 years ago • 2 comments

Steps to reproduce

  1. Use is in pipeline options page and clicks sync button on Pipeline.
  2. For whatever reasons sync fails and user is shown error.
  3. User navigates to a different pipeline's options page. Error message is still displayed.
  4. User clicks Sync Pipeline. Error message is shown even if the Sync is success

Expectation

  • [x] Once user navigates out of pipeline options page, error message should be cleared.
  • [ ] Even with in the same pipeline options page, if user clicks Sync again and if it succeeds, then error message should be cleared.

jithine avatar Oct 19 '17 19:10 jithine

#1 should be solved with the above PR. Not sure if #2 is solved yet.

tkyi avatar Jul 03 '18 18:07 tkyi

#1 should be solved with the above PR. Not sure if #2 is solved yet.

  1. won't be solved by the above PR, it should be handled in .done handlers for the promises whose failure sets the error message.

jithine avatar Jul 05 '18 03:07 jithine