screwdriver icon indicating copy to clipboard operation
screwdriver copied to clipboard

Meta post pull request comments is noisy

Open anilkumarmyla opened this issue 6 years ago • 5 comments

What happened: Meta post pull request comments is noisy if multiple commits/multiple builds happen for a pull-request

What you expected to happen: Ability to tweak the behavior of posting comments to only updating the same comment or deleting old comment and adding new comment. For reference codecov bot has pull request comments behavior https://docs.codecov.io/docs/pull-request-comments#section-behavior which can tweak the post comments behavior

How to reproduce it: Open a PR, start multiple builds for the same commit or have multiple commits trigger build. Each build posts a new comment

anilkumarmyla avatar Aug 08 '19 18:08 anilkumarmyla

This should be doable. Might be easiest to just update the comment rather than try to delete and create. I don't think this necessarily would need to be configurable. Users should be able to see edit history of comment if they really want to look at old comments.

Screen Shot 2019-08-08 at 2 03 29 PM

Implementation

  • Will probably need to add logic in scm-github to check if a comment exists which has a user.login that matches sd-buildbot/the default commenter.
    • If it exists, get the ID and update the comment.
    • If it doesn't exist, create a new comment (current behavior).
  • Probably do not need to change models.

tkyi avatar Aug 08 '19 21:08 tkyi

👍

anilkumarmyla avatar Aug 12 '19 20:08 anilkumarmyla

Hi @tkyi! I would like to work on this issue.

supra08 avatar Mar 15 '20 20:03 supra08

Looks like edit is not working and is creating new comments.

jithine avatar Jun 02 '20 01:06 jithine

@dwighthubbard looks like this is a known issue

jithine avatar Oct 18 '21 17:10 jithine