screwdriver
screwdriver copied to clipboard
Meta post pull request comments is noisy
What happened: Meta post pull request comments is noisy if multiple commits/multiple builds happen for a pull-request
What you expected to happen: Ability to tweak the behavior of posting comments to only updating the same comment or deleting old comment and adding new comment. For reference codecov bot has pull request comments behavior https://docs.codecov.io/docs/pull-request-comments#section-behavior which can tweak the post comments behavior
How to reproduce it: Open a PR, start multiple builds for the same commit or have multiple commits trigger build. Each build posts a new comment
This should be doable. Might be easiest to just update the comment rather than try to delete and create. I don't think this necessarily would need to be configurable. Users should be able to see edit history of comment if they really want to look at old comments.
Implementation
- Will probably need to add logic in scm-github to check if a comment exists which has a
user.loginthat matchessd-buildbot/the default commenter.- If it exists, get the
IDand update the comment. - If it doesn't exist, create a new comment (current behavior).
- If it exists, get the
- Probably do not need to change models.
👍
Hi @tkyi! I would like to work on this issue.
Looks like edit is not working and is creating new comments.
@dwighthubbard looks like this is a known issue