Jin

Results 113 comments of Jin

Yes, this is pretty annoying. I'd expect this feature to be wired up to `repository_ctx.download`, and not a rules_jvm_external specific feature though.

> Could rules_jvm_external avoid producing mirror_urls for entries in maven_install.json? This could be switched either globally or per-artifact, or best (and slowest) of all, based on testing each artifact in...

The repository url is passed to Coursier as-is. If Coursier doesn't support this feature, we don't the ability to do so as well.

This is not yet released in a bazel version, but would be a nice feature for someone to pick up on :)

If we didn't have to use a custom import rule, that'd be great. I'm just mostly concerned with introducing churn to the native Java rules, which AFAIK, is undergoing Starlarkification....

Thanks for the update! We may not be able to immediately use java_import if that means imposing a Bazel 5.2 restriction on using rules_jvm_external however, for compatibility reasons.

Release schedules have been fairly arbitrary, will take a look!

Should we have this as an opt-in feature per artifact? That is, ```python maven_install( artifacts = [ maven.artifact("group.id", "artifact", "1.2.3", export_transitive_compile_deps = True), ], ) ``` instead of applying this...

@shs96c what do you think? I think this is a more controllable approach than a `maven_install` wide implementation.