Jin
Making it at a global level will most likely to cause most targets to depend on a much, much larger compile time classpath than they actually require. e.g. https://github.com/bazelbuild/rules_jvm_external/blob/027db9779776f7ad79d39fde1f7d634a5825dc3c/regression_testing_install.json#L5262-L5282 brings...
With https://github.com/bazelbuild/rules_jvm_external/pull/285, auto-suggestions for `buildozer`'s `add dep` feature now works with artifacts pulled in by `maven_install`. That is, Bazel's strict-java-deps plugin will report this error when using a class from...
Given there are no comments in JSON, we could add a key to the dictionary to make this obvious.
```python maven_install( artifacts = [ "io.sentry:sentry:1.5.3", "com.fasterxml.jackson.core:jackson-core:2.6.7", ], repositories = [ "https://repo1.maven.org/maven2", ], ) ``` generates ```json { "dependency_tree": { "__AUTOGENERATED_FILE_DO_NOT_MODIFY_THIS_FILE_MANUALLY": 859617216, "conflict_resolution": { "com.fasterxml.jackson.core:jackson-core:2.6.7": "com.fasterxml.jackson.core:jackson-core:2.8.7" }, "dependencies": [ {...
I guess it doesn't print the conflict resolution if you depend on something that depends on `jackson-core`: ```python maven_install( artifacts = [ "io.sentry:sentry:1.5.3", "com.fasterxml.jackson.core:jackson-databind:2.6.7", ], repositories = [ "https://repo1.maven.org/maven2", ],...
I addressed this previously in https://github.com/bazelbuild/rules_jvm_external/issues/38 with the rationale that this rule is single purposed on resolving and fetching Maven artifacts, and adding Java annotation processing features will diverge from...
Let's move forward with this. Dagger, Auto-* and other annotation processors are core to many builds, and the API to integrate with them using the spec helper approach is a...
@shs96c do you still have the patch for this?
Assigning you to this issue as well, but no hurry :)
Oh! That's an edge case I haven't thought about. This script currently doesn't handle those unpinned repos correctly, because the maven_install.json are pulled from the dependencies as well. cc @borkaehw...