rules_jvm_external icon indicating copy to clipboard operation
rules_jvm_external copied to clipboard

Can't add maven local under `maven_install`'s repository

Open ThomasCJY opened this issue 4 years ago • 4 comments

I'm trying to add maven local repository under maven_install but seems like it doesn't support this currently.

What I did is

maven_install(
    name = "mvn",
    artifacts = [
        # Add all Android third-party deps here:
    ],
    repositories = [
        "https://maven.google.com",
        "file://localpath",
    ],
    version_conflict_policy = "pinned",
)

The file:// path will not be recognized

ThomasCJY avatar Dec 04 '19 01:12 ThomasCJY

The repository url is passed to Coursier as-is. If Coursier doesn't support this feature, we don't the ability to do so as well.

jin avatar Dec 06 '19 17:12 jin

@jin It seems that you explicitly forbid protocols other than http(s): https://github.com/bazelbuild/rules_jvm_external/blob/f0a1fc8b760c86c7d5107130559ecab4d58173c7/coursier.bzl#L725

utikeev avatar Mar 10 '20 16:03 utikeev

I'd like to be able to have some pattern for consuming local dependencies for migration purposes: I have sbt-plugins that have a core library that needs to be used from a genrule.

joprice avatar Apr 16 '20 14:04 joprice

Is this something we are comfortable with adding support for? @jin

benjaminRomano avatar Feb 18 '21 18:02 benjaminRomano