Jan Pieter Waagmeester
Jan Pieter Waagmeester
@ynerant contributions welcome!
@wsldankers The change makes sense, thanks! I think we should update the documentation too, can you maybe add a commit doing that?
I just updated a bunch of requirements, can you test again using master?
@natehawkboss Thanks for the explanation, makes sense. You are welcome to open a PR adding this split.
Correct, I never had the need to have multiple tables with filters. A sufficiently tested PR adding such a view would be welcome.
@benmehlman docs, flake8 and black are failing currently, I suspect running `black .` will cure the latter two. As for the docs, the errors are a bit buried in deprecation...
Please ignore the notifications of me trying to fix the base of this PR, which seems to be resolved now. With this patch, a couple of tests fail. I think...
I'm sorry for the inconvenience I caused, I suspected it was a simple fix just before merging.
I added a test to reproduce this, but I was not able to reproduce this error. ```python def test_datetime_xls(self): """Verify datatime objects can be exported to xls.""" utc = pytz.timezone("UTC")...
Ah, I missed the correct call `View.as_view()(build_request("/?_export=xls"))` or `View.as_view()(build_request("/?_export=xlsx"))` but adding that doesn't make the test fail. ```python response = View.as_view()(build_request("/?_export=xls")) self.assertIn("2019-07-22 13:11:11".encode(), response.content) ``` passes just fine.