django-tables2
django-tables2 copied to clipboard
jieter
Issue #687 Added ability to specify query and fragment elements of url via linkify.
Squashed commit of the following:
commit f0199f22905843dab101a122545ea897aa2aa60a Author: Ben Mehlman [email protected] Date: Wed Nov 6 15:07:42 2019 -0500
When passing linkify as dict, QUERY and FRAGMENT now lowercase (ie. query, fragment).
Update documentation to explain these features.
commit e14b5296f98d00b17b4a368aba7401da49bd5c67 Author: Ben Mehlman [email protected] Date: Tue Nov 5 22:22:01 2019 -0500
Add query string and fragment identifier capability to linkify.
Sorry, it looks like I've messed up the documentation somehow.. but Travis doesn't tell me the actual spelling error... If you could tell me what I've messed up I'll fix it, thanks!
@benmehlman docs, flake8 and black are failing currently, I suspect running black . will cure the latter two.
As for the docs, the errors are a bit buried in deprecation warnings and progress reporting, but the relevant error seems to be:
pages/api-reference.rst:65:url:["URL", "curl", "purl", "hurl", "burl", "furl", "Burl", "urn", "Erl", "yml", "arg"]
using uppercase URL will fix it, or add url to docs/spelling_wordlist.txt
Ok.. added tests for the new code to test_linkcolumn (in addition, added pass-through of new parameters from LinkColumn to linkify and updated docs for LinkColumn)... All tests pass.