Josh Holbrook comments

Results 154 comments of


                                            Josh Holbrook

Serve file with default ext is same name dir cannot be shown

This issue is also likely relevant - in a similar location in the code and probably worth wrapping into the same PR: https://github.com/jfhbrook/node-ecstatic/issues/88

Special characters in filename (檔案.html) prevent archiving

The *point* of this file is to test special characters support. If you need a package without these files, use the npm package, which doesn't include test. If you need...

Use 200.html as a fallback before 404.html

Hey, just now seeing this. Will try to review in the next few days.

Use 200.html as a fallback before 404.html

So, uh, yeah! Github's new review feature is _okay_.

Use 200.html as a fallback before 404.html

Last thought: Is this testable?

Use 200.html as a fallback before 404.html

I lied: Do you think this PR solves a similar problem as https://github.com/jfhbrook/node-ecstatic/pull/146 ?

Use 200.html as a fallback before 404.html

Feel free to PR some clarifying docs @mk-pmb

Add a logging option

Yeah I could get behind a simple CLF-based logging format

Add a logging option

I think it's a reasonable stance to say that ecstatic's logging should be extremely lightweight and intended for stdout only. If this means pulling in a module this is OK,...

Add a logging option

idk about sub-middlewares (I've been toying with the idea of moving away from express middleware support for well over a year now anyway), but a `log` property on the existing...