Josh Holbrook

Results 51 issues of Josh Holbrook

TL;DR - [The most valuable thing ecstatic can do for the JavaScript ecosystem](https://github.com/request/request/issues/3142) is to self-destruct, never to cut a new release again. # 2009 I once had a friend...

#247 flagged an issue where many (non-404) status codes aren't respecting handleError=false and always respond with an ecstatic-served error page. I think error handling in ecstatic is a little bizarre...

https://github.com/jfhbrook/pickleback This will allow us to test ecstatic without spinning up real servers on real ports. This could be part of a greater effort to refactor the tests, which cover...

The directory structure of this module is basically exactly what nodejitsu was using in 2011/2012. Things have changed! It would be cool, for instance, if instead of `require('ecstatic').mime` you could...

I have reasons to believe that the charset library that's intended to guess at charsets for content-types is actually just trying to parse them out of the existing content-type mimetype...

airbnb linting rules are a moving target, and it's currently making it difficult to upgrade the airbnb rules - which in turn is making it difficult to upgrade eslint! We're...

If you accidentally have HTTP_PROXY-related env vars configured, this can severely confuse the tests. Probably the best approach is to document this edge case. If you run into this issue,...

Via @mk-pmb : > I think a good solution would be to refactor a lot of these patterns into a test helper module (maybe `setup-loopback-listen`): > - Find a random...

I'd be really curious to see what that would even look like. I honestly don't know hapi's plugin API that well.

Right now, there's next to no testing for ecstatic in windows and it's only due to the odd windows user that issues with windows are detected. It's my understanding that...