Josh Holbrook
Josh Holbrook
Yes that’s the correct commit.
I just published 3.3.2 with the backported fix. This may help.
``` $ npm view ecstatic versions --json [ "2.2.2", "3.3.2", "4.1.2" ] ``` If you're using v1, I'm sorry but you'll have to upgrade.
Good point, I'll email those guys and see what they say.
I don't plan on patching 2.1.x. Looking at the changelog it should be a fairly simple and painless upgrade path. Arguably, as an aside, a multi-million dollar banking app should...
Against my better judgement, npm unilaterally republished everything so we should be good
A statement on my end that might be relevant to the interests of people following this issue: https://github.com/jfhbrook/node-ecstatic/issues/259
Forgive my thread necromancy! My concern with this PR as it stands is that a lot of people use this module outside the context of ecstatic, where this flag is...
Something that might be helpful for me is breaking tests for the behavior in express - this would give me a spec to work against.
This sounds like good stuff - I believe https://github.com/jfhbrook/node-ecstatic/blob/master/lib/ecstatic.js#L352-L371 is the code that would need to be refactored. A number of new tests would need to be written as well....