Results 396 comments of Jérôme Dockès

why close the issue? the first part (getting the variable names) has been implemented, but from the discussion there doesn't seem to be a conclusion on the second part (`store_default`...

renamed the issue as the part that was in the title has been implemented already

thanks @rcap107 I think that's a great idea. it would make an even bigger part of the tablereport's functionality conveniently available from the default tab panel (and the keyboard). to...

I think it's better to let graphviz do its thing with the svg generation and not mess with it so I suggest we close this. If using xlink:title was a...

thanks @MarieSacksick and @JulietteBgl I like your option 2. The parameter could be named something like `with_plots`: Boolean, whether to generate histograms or not. default is "if it's cheap". The...

it would be great to decide on this before 0.7.0 in case the `max_*_columns` need to be deprecated

> By default, both flags are set to True, and the threshold is set in the configuration as it is now I think "from_config" (use the threshold) should be the...

If you change the last line to this: ```python vectorized = x.skb.apply(HashingVectorizer(), how="full_frame") ``` it works and returns a sparse matrix. The name "full_frame" should probably be changed to something...

``` >>> import skrub >>> from sklearn.preprocessing import StandardScaler >>> from sklearn.feature_extraction.text import HashingVectorizer >>> df = skrub.toy_orders().X >>> x = skrub.var("x", df) as the input is a dataframe we...

as you can see for the standardizer above, when X is not a dataframe it already goes to the "full_frame" mode. the problem is when the input X is a...