Jérôme Dockès comments

Results 396 comments of


                                            Jérôme Dockès

Interactivity for reporting of skrub

indeed, replacing the simple SVG with plotly figures would jeopardize a key feature of the tablereport: that it tends to always work and display correctly in different environments and screen...

FEA - Add a selector for columns that contain lists

given that there are not only Lists but also Arrays and Structs, and that just "list" without reference to a specific dtype may be ambiguous (e.g. should pandas object series...

FEAT - Add an `Apply` transformer that automatically chooses the correct ApplyTo depending on the transformer

it's a function you need, and it already exists (wrap_transformer) -- you just need to come up with a better name & expose it in the public API

FEAT - Add an `Apply` transformer that automatically chooses the correct ApplyTo depending on the transformer

> We just need to expose it as an object. do you mean a transformer class, and if so why do you think it is needed rather than just a...

FEAT - Add an `Apply` transformer that automatically chooses the correct ApplyTo depending on the transformer

rather than ApplySeparateCols I would suggest ApplyOnEachCol which is shorter and highlights the fact that the transformation is done independently on each column by using the singular and "each" Normally...

FEAT - Extend the `has_nulls` selector so it can take a fraction of null values

yeah maybe that's a good alternative to #1723 and #1714 , letting users easily select such columns and do what encoding they prefer with them