Jérôme Dockès

@glemaitre had started working on that in #1051

not computing the associations under a certain sample size makes sense. or we could also change the conditions under which we show the red "warning". The cramer V is an...

Thanks for opening this! Both hoidays and temporal patterns sound useful **holidays:** As you say there is the problem that we would need another dependency to get the holidays. However...

I didn't have in mind the ensemble aspect but rather the fact that non-linear models might be able to cope better with the raw features by themselves. For example given...

> Ah good that you point that out, it's a subtle difference. I guess even with a non-linear model the featurization technique can also be seen as a way to...

We discussed it this morning during the skrub meeting (you're welcome to join whenever you want by the way, it's every Monday 10:30 to 11:00 in Europe/Paris, if you're interested...

In [this example](https://scikit-learn.org/stable/auto_examples/applications/plot_cyclical_feature_engineering.html#sphx-glr-auto-examples-applications-plot-cyclical-feature-engineering-py) the sine features seem to perform worse than the splines or than simple one-hot encoding of the hour

> Stuff like holidays, which could be seen as a sort of seasonal feature, is out of scope here. I agree, holiday/weekend are a different issue -- they're just a...

Discussing a bit with @ogrisel and @glemaitre we were thinking that for most things that are likely to be relevant, the shape of the splines that are flat with a...

I also wonder if the current interface of the DatetimeEncoder is suitable for adding those features or if parameters should be in terms of "which cycles to represent" rather than...