Results 396 comments of Jérôme Dockès

> Nitpick: I think that it should be called "TableReport" :) good point -- we may want to add other kinds of reports eg on models

thanks!! for now I have added one in example 01, we can see it in the [circleCI artifact](https://output.circle-artifacts.com/output/job/bc33c06b-6a52-4000-85b4-82be4c704255/artifacts/0/doc/auto_examples/01_encodings.html#easy-learning-on-a-dataframe) I think we're not too far from being able to start the...

I have a question: the reports require matplotlib and jinja2; should those be required or optional dependencies? In my experience it is a bit annoying when dependencies for a rather...

Note: to try the command-line script you probably need to install skrub again, even if it was installed in editable mode ``` pip install -e . skrub-report /my/file.parquet ```

> With regards to the tooltips, can you make them appear without waiting I made this change but looking a them again I'm not sure they are really useful, we...

> I think that they are super useful. I would favor keeping them: they help understanding what is going on, but do not clutter ok then, let's keep them!

> I wonder if this PR has been mixed with other things: are all lines in the diff related to the PR? yes except a few small details (handling a...

> @jeromedockes : tell us when this is ready for merge ok I think probably today, I'm just adding a few docstrings in the private modules

> But 2.5k lines of diff are in the pixi.lock due to adding the matplotlib and jinja dependencies and another 2k lines in the `package-lock.json` of the javascript module used...

ok I'll have another look tomorrow but I think I have addressed most comments from @GaelVaroquaux