Jeremy Meng

Results 160 comments of Jeremy Meng

If we add it to `contentType?: string` to `OperationRequestOptions`, then we don't need to extend OperationOptions anymore? https://github.com/Azure/autorest.typescript/blob/fd3b2301af53644b7902ad001a5d7b54fac8d925/packages/typespec-ts/test/modularIntegration/generated/azure/core/src/models/options.ts#L9 or maybe there's a reason that this would not work but I...

> You mean to extend from OperationRequestOptions instead ? I think the reason we have to extend from OperationOptions No, we could still extends `OperationOptions` in code gen. What I...

I see, we want to keep some of current customer experiences of specifying contentType in options. It feels that specifying it via headers would mostly work, but not as convenient...

@gilesbradshaw Thanks for the report! Unfortunately our support policy only includes the LTS versions of NodeJS. Is it possible for you to either migrate to newer version of NodeJS, or...

per discussion at https://github.com/nodejs/node/pull/51356#issuecomment-1876895325, targeting v21.x-staging

> According to [reverting commits docs](https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#reverting-commits), you only need to include `Fixes: #PR` in the PR message, can you update that? Done

List of commits in 18.17.1 > Commits [[fe3abdf82e](https://github.com/nodejs/node/commit/fe3abdf82e)] - deps: update archs files for openssl-3.0.10+quic1 (Node.js GitHub Bot) [#49036](https://github.com/nodejs/node/pull/49036) [[2c5a522d9c](https://github.com/nodejs/node/commit/2c5a522d9c)] - deps: upgrade openssl sources to quictls/openssl-3.0.10+quic1 (Node.js GitHub Bot)...

we switched to c8 and vitest

@javache that's right. Thanks for pointing it out. Maybe I could change to call the setter in the constructor. Still currently BlobModule is not required. With the change it will...