Jeremy Meng

Results 160 comments of Jeremy Meng

The conditional export feature may be a solution. - https://nodejs.org/docs/latest-v16.x/api/packages.html#conditional-exports - https://nodejs.org/docs/latest-v16.x/api/packages.html#dual-commonjses-module-packages Our current setup is close to Approach 2 We need to be careful about state though

@subhod-i I tested the scenario and PR #22804 appears to have addressed the issue. Will continue working on getting it merged.

@subhod-i also it looks like an issue in create-react-app v4. The latest v5 worked fine for me without changes from PR #22804

Some references: https://stackoverflow.com/questions/71054449/cant-import-the-named-export-directive-from-non-ecmascript-module-only-defau https://github.com/facebook/create-react-app/issues/10356 https://stackoverflow.com/a/72959074/2170938

I did some testing with @subhod-i's repro project. With PR #22804, webpack 4 now reports a different error: > Attempted import error: 'RestError' is not exported from '@azure/core-rest-pipeline'. Importing from...

It is still not clear to me why from a .mjs file, webpack couldn't use the `module` field in our package.json. However, the following workaround seems to work for me...

> webpack@4 has a quirk, but it is doable to fix this on the side of your package, e.g. using mjs extension or adding `"type": "module"` to package.json @davidyuk I...

@gitnwana Could you please provide more details on how you relay messages in JavaScript? Some code snippets would be great too! > Since past week we are noticing a certain...

@gitnwana could you please enable more detailed logs as described above? We should be able to see what messages are going out if it is sent by the client SDK.

@asdaandrewhaigh a fix has been merged in PR #23232. It should be available in the next version of identity soon.