ms-rest-js
ms-rest-js copied to clipboard
Azure
breaking change between 1.11.1 and 1.11.2
Package Version: 1.11.2
- [ ] nodejs
- nodejs version: node:12.14.1-alpine
- os name/version: node:12.14.1-alpine
- [ ] browser
- name/version: ____ Describe the bug A clear and concise description of what the bug is.
This breaks semantic versioning - not all your 1.x.x run on node 12..
see here for consequence: https://github.com/tediousjs/node-mssql/issues/1600
To Reproduce Steps to reproduce the behavior:
dockerfile
FROM node:12.14.1-alpine
WORKDIR /app
COPY ./package.json /app
RUN yarn
package.json
{
"name": "account",
"version": "0.0.1",
"main": "index.js",
"license": "MIT",
"dependencies": {
"@azure/ms-rest-js": "1.11.2"
}
}
Expected behavior A clear and concise description of what you expected to happen.
should install ok (as for all previous 1.x.x
Screenshots If applicable, add screenshots to help explain your problem.
docker build .
[+] Building 7.0s (8/8) FINISHED docker:default
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 109B 0.0s
=> [internal] load metadata for docker.io/library/node:12.14.1-alpine 0.7s
=> [1/4] FROM docker.io/library/node:12.14.1-alpine@sha256:1dd4309479f031295f3dfb61cf3afc3efeb1a991b012e105d1a95efc038b72f6 0.0s
=> [internal] load build context 0.0s
=> => transferring context: 188B 0.0s
=> CACHED [2/4] WORKDIR /app 0.0s
=> CACHED [3/4] COPY ./package.json /app 0.0s
=> ERROR [4/4] RUN yarn 6.3s
------
> [4/4] RUN yarn:
0.591 yarn install v1.21.1
0.616 info No lockfile found.
0.622 [1/4] Resolving packages...
2.336 warning @azure/ms-rest-js > [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
3.570 [2/4] Fetching packages...
5.018 error @azure/[email protected]: The engine "node" is incompatible with this module. Expected version ">=14.0.0". Got "12.14.1"
5.030 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
5.030 error Found incompatible module.
------
Dockerfile:4
--------------------
2 | WORKDIR /app
3 | COPY ./package.json /app
4 | >>> RUN yarn
5 |
--------------------
ERROR: failed to solve: process "/bin/sh -c yarn" did not complete successfully: exit code: 1
Additional context Add any other context about the problem here.
@gilesbradshaw Thanks for the report! Unfortunately our support policy only includes the LTS versions of NodeJS. Is it possible for you to either migrate to newer version of NodeJS, or pin the version of either @azure/ms-rest-js or @azure/core-auth to a previous working one?
Note that 1.11.0 has this bug https://github.com/Azure/ms-rest-js/issues/428. The dependency on @azure/core/auth is introduced in 1.10.0.
