node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

[v21.x] Revert "fs: remove workaround for `esm` package"

Open jeremymeng opened this issue 1 year ago • 6 comments

Fixes: #51081

jeremymeng avatar Jan 06 '24 00:01 jeremymeng

per discussion at https://github.com/nodejs/node/pull/51356#issuecomment-1876895325, targeting v21.x-staging

jeremymeng avatar Jan 06 '24 00:01 jeremymeng

CI: https://ci.nodejs.org/job/node-test-pull-request/56739/

nodejs-github-bot avatar Jan 10 '24 22:01 nodejs-github-bot

you only need to include Fixes: #PR in the PR message, can you update that?

No need to modify the commit message for that, you can edit the PR description and it will be picked up by ncu and added to the commit message upon landing. But not sure if we use the same process for landing PRs on staging branches.

aduh95 avatar Jan 10 '24 22:01 aduh95

According to reverting commits docs, you only need to include Fixes: #PR in the PR message, can you update that?

Done

jeremymeng avatar Jan 10 '24 23:01 jeremymeng

@RafaelGSS Because the esm package is archived and will never be fixed.

targos avatar Feb 15 '24 14:02 targos

CI: https://ci.nodejs.org/job/node-test-pull-request/57099/

nodejs-github-bot avatar Feb 15 '24 14:02 nodejs-github-bot

Rebased to include https://github.com/jeremymeng/node/commit/83f581d4c1a12fae91bddbdddf91c643afaf7197

targos avatar Feb 20 '24 07:02 targos

CI: https://ci.nodejs.org/job/node-test-pull-request/57192/

nodejs-github-bot avatar Feb 20 '24 08:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57263/

nodejs-github-bot avatar Feb 21 '24 19:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57264/

nodejs-github-bot avatar Feb 21 '24 19:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57275/

nodejs-github-bot avatar Feb 21 '24 21:02 nodejs-github-bot

@jeremymeng rebased

marco-ippolito avatar Feb 26 '24 08:02 marco-ippolito

CI: https://ci.nodejs.org/job/node-test-pull-request/57458/

nodejs-github-bot avatar Feb 27 '24 11:02 nodejs-github-bot

🟢 GREEN CI: https://ci.nodejs.org/job/node-test-pull-request/57460/

nodejs-github-bot avatar Feb 27 '24 14:02 nodejs-github-bot

Landed in f130a334384

marco-ippolito avatar Mar 01 '24 12:03 marco-ippolito