jerempy

Results 21 comments of jerempy
trafficstars

@samhita-alla I opened a PR for this: https://github.com/flyteorg/flytekit/pull/1236 Could you assign the issue to me?

@stnguyen90 thanks for respondng so fast. Something came up though and I probably won’t be able to contribute so I wanted to let you know quickly so it can be...

I took a shot at handling this issue. PR open 😎

@abooij Thanks for the reply and insight! Makes sense. I took another shot at it. lemme know what you think.

@abooij thanks for the insight and patience. I took another shot - 🤞 i got it

Hopefully last commit gets diff coverage up

@pingsutw hey there, I’m doing some re work on the flyteadmin pr which will influence how this one is implemented. Shouod hopefully wrap that soon and then make the necessary...

@pingsutw I;'d say yes. I think I miss the original ask from the issue - as I am not comparing the diffs between existing workflow and the one returned. However...

@samhita-alla thanks for the comment! I tried running pylint on files with `FlyteFile[typing.TypeVar("...")]` and it wasn't causing breakages. the original breakage was caused by assigning types to variables with different...