Update to include request and error message fix #2522

[jerempy]

trafficstars

will make it so at least there is more information to help debug - goes with changeset in the flyeadmin pr with same issue number: https://github.com/flyteorg/flyteadmin/pull/487

TL;DR

Makes it so there is more data if a workflow already exists but with different structure. More data will appear in logs as well as in the raised exception in the console.

Type

• [x] Bug Fix
• [ ] Feature
• [ ] Plugin

Are all requirements met?

• [x] Code completed
• [ ] Smoke tested
• [ ] Unit tests added
• [ ] Code documentation added
• [ ] Any pending items have an associated Issue

Complete description

Added more data in the flyteadmin PR and then add on the more data to the exception details when raised as part of the _handle_invalid_create_request decorator in the raw client

Tracking Issue

Fixes https://github.com/flyteorg/flyte/issues/2522

Follow-up issue

NA OR https://github.com/flyteorg/flyte/issues/

[welcome[bot]]

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

• Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
• Sign off your commits (Reference: DCO Guide).

[codecov[bot]]

Codecov Report

Merging #1235 (d8e3afd) into master (caf612d) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
+ Coverage   68.66%   68.73%   +0.06%     
==========================================
  Files         288      288              
  Lines       26359    26380      +21     
  Branches     2490     2492       +2     
==========================================
+ Hits        18100    18132      +32     
+ Misses       7780     7764      -16     
- Partials      479      484       +5     

Impacted Files	Coverage Δ
setup.py	0.00% <ø> (ø)
flytekit/clients/raw.py	26.49% <100.00%> (+4.20%)	:arrow_up:
tests/flytekit/unit/clients/test_raw.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jerempy]

Hopefully last commit gets diff coverage up

[pingsutw]

@jerempy Could you help resolve the linting errors by running make fmt?

[jerempy]

@pingsutw hey there, I’m doing some re work on the flyteadmin pr which will influence how this one is implemented. Shouod hopefully wrap that soon and then make the necessary changes here and I will pass lint before pushing

[pingsutw]

nice, thank you

[pingsutw]

@jerempy is it ready to be reviewed?

[jerempy]

@pingsutw I;'d say yes. I think I miss the original ask from the issue - as I am not comparing the diffs between existing workflow and the one returned. However this is an improvement and we should have better error messages now in the logger and stack trace that can help debug and probably be able to eyeball the diffs since flyteadmin and flyteidl PRs are now merged.

[welcome[bot]]

Congrats on merging your first pull request! 🎉