jerempy
jerempy
sorry @pingsutw if you could review again 🙏 :I noticed that I accidentally changed the return type in https://github.com/flyteorg/flytekit/blob/98acf1bd7a76f0b6f2d04cbeb87ac17b84b3836c/tests/flytekit/unit/core/test_realworld_examples.py#L87 so i reverted it back to featured_columns and class_columns
@pingsutw think we could merge this one? October is almost over 😅
@samhita-alla thanks for that! @eapolinario and @pingsutw you guys able to take a new look? I re-did the whole thing for `typing.Annotated` It looks good to both mypy and pylint
@eapolinario thanks for feedback! Can you review once more? I updated the import and while I was at it noticed that the `flytekit.types.FlyteDirectory` - was also using the new annotated...
@eapolinario woops! missed that one. got it now. should be good to go 😎
happy halloween! Looks like missing 7% diff coverage, based on lines of code - but when I look at the PR I;d say everything is adequately covered - if it...
> @jerempy If you compare with the video in issue and the screenshot in PR, the styles are different. @Navaneeth-pk thanks for the reply! I think we good to go...
@Navaneeth-pk mind taking a look again?
@ngjaying Added a PR to close this, linked above
ImageBlock gets added as a plugin here: https://github.com/globocom/megadraft/blob/1caecd3b3ced5e44c3990401f1f0542cb32e7a77/src/components/MegadraftEditor.js#L121 by default if you don't specify it as a plugin. What happens for you if you don't specify any plugins? I also...