jerch

Results 525 comments of jerch

@Tyriar The official docs state the following: - Windows: UTF-16 (see https://msdn.microsoft.com/en-us/library/dd374081.aspx), this source does not say anything about endianess, on a typical x86 Windows uses LE, probably they just...

@mirabilos Why would it be needed to treat this separately, why not just use existing API: ```typescript pty.spawn('/bin/sh', ['-sh', ...], ...) ```

@mirabilos Thx, found the piece of code, where it gets copied over as argv[0]. Is that '-' convention of `login` specced somewhere (maybe in POSIX?) or at least known to...

Looking at `child_process` its API supports an optional `argv0` setting in options, which defaults to the given command if not set. So yeah this might be the best way to...

@develerik Currently parts of node-pty are **not thread-safe** (like `ptsname`), thus it should never be used from concurrent workers. We cannot simply switch to `NAN_MODULE_WORKER_ENABLED` before resorting to thread-safe internals...

As I just went through this with a native addon, here are some remarks: Context aware aims for the ability to load a native module into different JS contexts (multiple...

I am a fan of a full rewrite of this lib, esp. to fix those nasty low level blocking bugs, and to expose somewhat more control to the outside (termios...

@daniel-brenot I hope you can find a better way around the POLLHUP issue on linux, than my noisy poll loop. Should be possible with a dedicated polling thread injecting the...

Sure thing. Another issue I want to point out before you get your hands dirty into the wrong direction - #487 and its issues behind. It deals with a recent...

If you mean with "process method" the pty & process creation step - thats actually another open issue (see #265). Ideally the lib exposes enough error state to the caller...