jerch

@Tyriar Does `node-pty` populate the process id correctly under windows? If so, maybe its possible to force kill it by an external command called with `childprocess.*`. Not a nice solution...

@t1m0thyj Cannot tell that for sure, imho `process.kill(ptyProcess.pid)` is similar to `pty.kill()` (would call the same C function from the same thread I guess), while a custom subprocess would run...

@t1m0thyj Then it is most likely some dangling resource in the C++ part, as @Tyriar already mentioned. You can try to call `unref()` on things like sockets used in the...

@Tyriar @Eugeny already addressed this issue in https://github.com/microsoft/node-pty/pull/487.

@simark You trigger the success event on `nextTick`, but it is not guaranteed that the exec call already happened in the forked process (the kernel process scheduler could have priorized...

Woops have overlooked this, yeah the CLOEXEC trick works for this.

Yeah, the fact that a failed exec* gets silently swallowed by the module, is less than ideal. @simark You already proposed a working patch for posix systems, would be nice...

> Not sure what you mean by failed process binary lookup... Sorry for sloppy wording - I mean whether it gives a meaningful error message, if the process binary lookup...

@Tyriar: Hard to say, this error will be thrown whenever the file descriptor `fd` is invalid: https://github.com/Microsoft/node-pty/blob/1c3cd4710c48ad45615da562d10d76162ad43c39/src/unix/pty.cc#L368 Possible reasons: - fd is something else (not a pty master at all)...

@Tyriar Imho the conversion is not needed at all since Windows uses internally a type of UTF-16 for `wchar_t` and so does Javascript (not sure though if they agree on...