jerch

Results 526 comments of jerch

It is kinda obvious, that things here might lead to a bigger API change. So its prolly better to discuss a few things to not get on the wrong track....

Out of your list (3) would be my favorite currently, as it does the least "damage" to current API and addon setup. 3rd party addons not needing the goodies will...

@Tyriar So how would you suggest to move on with this matter and the PR? The PR currently uses your (3) pattern from above providing the shared exports from the...

@Tyriar Ah no worries, didnt have much time myself in the last couple of months. Will see if I can get back to it by the next week.

@gwpl Well the sgr-pixel stuff is quite easy to implement (imho much easier than the DEC locator protocol). Whether it is easy to update the demo here idk, but you...

@Tyriar I am not sure, if the integration testing works correctly atm. There are several tests failing, but the CI does still mark them as successful. :thinking: Example: https://github.com/xtermjs/xterm.js/actions/runs/11170843380/job/31054434727?pr=5178#step:10:491

I have no clue yet, how to test that in the CI. Maybe it is possible to track the font asset loading somehow with playwright. The changing glyph metrics should...

@Tyriar Added some CI tests, ready for review.

@PerBothner I have not checked yet (and did not write the code). So there is a chance, that we are missing a piece, yes. About `Pc='p'`: What you describe, sounds...

@j4james Yes thats a problem with our library-like approach, in theory any integrator could overload whatever he wants coming up with a very own impl for detail xy. Not only...