jerch

Results 548 comments of jerch

Done with the basic C++ transition. Features of the new native lib: - fork & exec* from JS - full waitpid implementation exposed to JS - pty primitives exposed to...

OMG here comes the low level fun - OSX does not support pty file descriptors with `poll`. Not sure about kqueue support there, have to test it. Seems the `POLLHUP`...

Update: The poller works now with OSX (tested only on OSX 10.10 though). Edit: Done with the basic OS compat tests. Only minor adjustments were needed, the C++ part runs...

@Tyriar Started to move the module to TS and added some first basic tests. Please have a look at it, esp. with TS I need your help (not even sure,...

fork: The internal states of v8 should be save to be forked (JS code itself is synchronous), only problem I see here is node's event loop - libuv's event loop...

I think it is possible to drop the fork & exec stuff and use `childprocess.spawn` instead (as proposed in #134). Edit: See `test4.js` and `spawn2` for a `child_process` based version.

Yes that should work. The master (parent) callback is not needed though. I suggest to "enclose" the child completely in the callback and anything after `forkpty` would be parent context...

About `child_process` - it is currently not possible to use [`uv_spawn`](https://github.com/libuv/libuv/blob/v1.x/src/unix/process.c#L278) for that, it basically lacks the `TIOCSCTTY` ioctl, but it could be done with a helper binary (as `child_pty`...

Yes with the helper binary it works under all POSIX systems I can test here (see https://github.com/jerch/node-newpty/tree/child_process). Maybe we should build the unix stuff based on that idea? How hard...

I have implemented a separate STDERR pipe option. Tested with a small helper binary as direct child, grandchild (behind `bash -l`) and great-grandchild (`bash -l` && `bash -c HELPER`). The...