Jeff Schwartz

Results 96 comments of Jeff Schwartz

@jeffhandley I noticed that this future item is still marked as blocking-release. Is that still the case?

@janvorli can you do a code review? Same as https://github.com/dotnet/runtime/pull/67772

@lewing / @steveisok / @SamMonoRT the wasm tests are hitting a baseline failure. Can you take a look? https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs#L359 Expected subject to be a collection with 226 item(s), but found...

@lewing thanks. They look like restore 429's and will need a rerun once we have the fix for the wasm.

Thanks for taking a look, who has the next action on this investigation? We are about to snap for RC1 and this will soon become blocking. Thanks

adding @dotnet/domestic-cat, @LakshanF, and @MichalStrehovsky to see if they have insight into this new error. ```  /root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1083: The specified RuntimeIdentifier 'invalid-rid' is not recognized. [/root/helix/work/workitem/e/testExecutionDirectory/BuildFailsIfI---253526DD_2/RuntimePackNotAvailable/RuntimePackNotAvailable.csproj]  /root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5):...

An example is the following: https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests/WasmAoTPublishIntegrationTest.cs#L62 No rid seems to be passed. Was there a recent change in the SDK that requires that (eg. no implicit rid any longer)?

Lakshan and I took a deeper look. It seems that one of the errors is a red herring (as the test is expecting that), the other implies a restore failure...

This failure is durable: > C:\h\w\B18109B0\p\d\dotnet.exe msbuild /t:Publish C:\h\w\B18109B0\t\dotnetSdkTests\mruxzlnv.mbh\AoT_Publish_W---DA56BF44\blazorwasm\blazorwasm.csproj /restore /p:Configuration=Release MSBuild version 17.4.0-preview-22414-01+50f6081be for .NET Determining projects to restore... C:\h\w\B18109B0\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1183: Unable to optimize assemblies for Ahead of...