Jeff Schwartz
Jeff Schwartz
@sharwell I am having a hard time understanding the motivation and underlying value of these changes. Can you help me understand? The net-net of the change is removal of one...
@sharwell What case is failing today with the current implementation? In my mind the well-behaved case is load an ETL, process it, then shutdown the process. We do this regularly...
We do that all the time - this is a common case. What is the result when this happens? I am seeing it succeed. Related, what portion of this change...
Debug TraceEvent has a number of issues - it is noble and much needed to clean those up. Though the asserts I have seen are far deeper within the setup...
To start please merge the relevant commits, after that I will then take a deeper look. The semantics for NeedProcesses and NeedLoadedDotNetRuntimes should be as follows: - On first call...
@sharwell merge as in merge the commits, not merge with master. Please collapse the changes so I can see the true deltas from the current source. What realworld scenarios are...
@sharwell as discussed please merge relevant commits and then I will take a deeper look.
This change looks good. Thanks for adding tests.
@mangod9 can you take a look at the crash? https://helix.dot.net/api/2019-06-17/jobs/c512be84-95cc-4395-8ca0-fafd95dfe3d3/workitems/Diagnostics.EFCore.FunctionalTests--net9.0/console looks like a dump was not uploaded
removing blocking-clean-ci has this has not failed in 30 days 24-Hour Hit Count | 7-Day Hit Count | 1-Month Count -- | -- | -- 0 | 0 | 0