sdk
sdk copied to clipboard
dotnet
[main] Update dependencies from dotnet/runtime
This pull request updates the following dependencies
From https://github.com/dotnet/runtime
- Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
- Build: 20220813.1
- Date Produced: August 13, 2022 11:01:04 AM UTC
- Commit: 625fb02cb44590bb2d01beda8ab3ca36116f2950
- Branch: refs/heads/main
- Updates:
- Microsoft.DotNet.ILCompiler: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- Microsoft.Extensions.DependencyModel: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- Microsoft.NET.HostModel: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- Microsoft.NETCore.App.Ref: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- Microsoft.NETCore.Platforms: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- System.CodeDom: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- System.Reflection.MetadataLoadContext: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- System.Resources.Extensions: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- System.Security.Cryptography.ProtectedData: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- System.Text.Encoding.CodePages: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-rc.1.22411.12 to 7.0.0-rc.1.22413.1
![dotnet-maestro[bot] avatar](https://avatars.githubusercontent.com/in/16706?v=4 "Published by a pub.dev verified publisher"){kind=small}
Notification for subscribed users from https://github.com/dotnet/runtime:
@dnr-codeflow
Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
- This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
- If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
- For more details, please read the Arcade Darc documentation
Notification for subscribed users from https://github.com/dotnet/runtime:
@dnr-codeflow
Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
- This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
- If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
- For more details, please read the Arcade Darc documentation
@pavelsavara this looks familiar:
Microsoft.NET.Sdk.BlazorWebAssembly.Tests.BlazorWasmStaticWebAssetsIntegrationTest.StaticWebAssets_Publish_DoesNotIncludeXmlDocumentationFiles_AsAssets [FAIL]
Expected subject to be a collection with 235 item(s), but found 247.
@lewing / @steveisok / @SamMonoRT the wasm tests are hitting a baseline failure. Can you take a look?
https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs#L359 Expected subject to be a collection with 226 item(s), but found 238.
@javiercn can you have a look at the static web assets tests
@jeffschwMSFT there are several Microsoft.NET.Build.Tests failures that are not wasm related.
@lewing thanks. They look like restore 429's and will need a rerun once we have the fix for the wasm.
@javiercn @TanayParikh do you use some tool to generate the baselines for the blazor tests?
@javiercn @TanayParikh do you use some tool to generate the baselines for the blazor tests?
Yes. I believe it's just a matter of updating:
https://github.com/dotnet/sdk/blob/dc4f499509dfa708926ff6639bc800f78a00202f/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs#L29-L33
However, is this change expected?
@javiercn @TanayParikh do you use some tool to generate the baselines for the blazor tests?
Yes. I believe it's just a matter of updating:
Could you do that, please?
However, is this change expected?
I wouldn't know.
I can definitely do it, but just want to confirm if this is an expected change. I believe @pavelsavara has been making some changes in this area so he may have additional context?
What change are you talking about btw? You linked to:
#if GENERATE_SWA_BASELINES
public static bool GenerateBaselines = true;
#else
public static bool GenerateBaselines = false;
#endif
This hasn't changed in the last year.
This hasn't changed in the last year.
Essentially just need to add a #define GENERATE_SWA_BASELINES to the top of the file to trigger baseline generation instead of actually running the test.
what is the potential value of test StaticWebAssets_Publish_DoesNotIncludeXmlDocumentationFiles_AsAssets and is it still worth keeping? given how it is broken every other day, it is a constant catch up with "number of items in a manifest which we have no control over in this repository". seems like it is less of a protection (assuming this test has never caught anything useful?) and more of a design flaw hindering automated code flow which forces unnecessary actions from human.
deleting overeager and useless tests should be under consideration.
I can definitely do it, but just want to confirm if this is an expected change. I believe @pavelsavara has been making some changes in this area so he may have additional context?
Yes, we have added some source .ts and .js files from which the dotnet.js is composed. I'm not sure how exactly it impacts this test.
If you share the changes, then I could try to validate them.
I should be able to validate them too.
Thanks for taking a look, who has the next action on this investigation? We are about to snap for RC1 and this will soon become blocking. Thanks
Looks like we're seeing a new error now:
Microsoft.DotNet.Watcher.Tools.GlobbingAppTests.DeleteSourceFolder (and other tests)
Expected command to pass but it did not.
File Name: /root/helix/work/correlation/d/dotnet
Arguments: msbuild /t:Build /root/helix/work/workitem/e/testExecutionDirectory/DeleteSourceF---587A3DCE/WatchGlobbingApp.csproj /restore
Exit Code: 1
StdOut:
MSBuild version 17.4.0-preview-22414-01+50f6081be for .NET
Determining projects to restore...
/root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1183: Unable to optimize assemblies for Ahead of time compilation: a valid runtime package was not found. Either set the PublishAot property to false, or use a supported runtime identifier when publishing. When targeting .NET 7 or higher, make sure to restore packages with the PublishAot property set to true. [/root/helix/work/workitem/e/testExecutionDirectory/DeleteSourceF---587A3DCE/WatchGlobbingApp.csproj]
StdErr:
Does anyone have context on this error?
Previously:
Microsoft.NET.Sdk.BlazorWebAssembly.Tests.BlazorWasmStaticWebAssetsIntegrationTest.StaticWebAssets_Publish_DoesNotIncludeXmlDocumentationFiles_AsAssets [FAIL] Expected subject to be a collection with 235 item(s), but found 247.
Which isn't showing in the CI any longer.
adding @dotnet/domestic-cat, @LakshanF, and @MichalStrehovsky to see if they have insight into this new error.
[m[37m /root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1083: The specified RuntimeIdentifier 'invalid-rid' is not recognized. [/root/helix/work/workitem/e/testExecutionDirectory/BuildFailsIfI---253526DD_2/RuntimePackNotAvailable/RuntimePackNotAvailable.csproj]
[m[37m /root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1183: Unable to optimize assemblies for Ahead of time compilation: a valid runtime package was not found. Either set the PublishAot property to false, or use a supported runtime identifier when publishing. When targeting .NET 7 or higher, make sure to restore packages with the PublishAot property set to true.
Likely a test issue? Not sure where the test is though to check.
Both the errors, NETSDK1083 and NETSDK1183 seem valid when rid is "invalid-rid"
An example is the following: https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests/WasmAoTPublishIntegrationTest.cs#L62
No rid seems to be passed. Was there a recent change in the SDK that requires that (eg. no implicit rid any longer)?
Lakshan and I took a deeper look. It seems that one of the errors is a red herring (as the test is expecting that), the other implies a restore failure - so rerunning.
This failure is durable:
> C:\h\w\B18109B0\p\d\dotnet.exe msbuild /t:Publish C:\h\w\B18109B0\t\dotnetSdkTests\mruxzlnv.mbh\AoT_Publish_W---DA56BF44\blazorwasm\blazorwasm.csproj /restore /p:Configuration=Release
MSBuild version 17.4.0-preview-22414-01+50f6081be for .NET
Determining projects to restore...
C:\h\w\B18109B0\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1183: Unable to optimize assemblies for Ahead of time compilation: a valid runtime package was not found. Either set the PublishAot property to false, or use a supported runtime identifier when publishing. When targeting .NET 7 or higher, make sure to restore packages with the PublishAot property set to true. [C:\h\w\B18109B0\t\dotnetSdkTests\mruxzlnv.mbh\AoT_Publish_W---DA56BF44\blazorwasm\blazorwasm.csproj]
Given this Wasm, I am not sure why this error is firing. @lewing?
This failure is durable:
> C:\h\w\B18109B0\p\d\dotnet.exe msbuild /t:Publish C:\h\w\B18109B0\t\dotnetSdkTests\mruxzlnv.mbh\AoT_Publish_W---DA56BF44\blazorwasm\blazorwasm.csproj /restore /p:Configuration=Release MSBuild version 17.4.0-preview-22414-01+50f6081be for .NET Determining projects to restore... C:\h\w\B18109B0\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1183: Unable to optimize assemblies for Ahead of time compilation: a valid runtime package was not found. Either set the PublishAot property to false, or use a supported runtime identifier when publishing. When targeting .NET 7 or higher, make sure to restore packages with the PublishAot property set to true. [C:\h\w\B18109B0\t\dotnetSdkTests\mruxzlnv.mbh\AoT_Publish_W---DA56BF44\blazorwasm\blazorwasm.csproj]Given this Wasm, I am not sure why this error is firing. @lewing?
Does this generate bin logs, and can I access those?
There do not appear to be binlogs: https://dev.azure.com/dnceng/public/_build/results?buildId=1946548&view=ms.vss-test-web.build-test-results-tab&runId=50128994&resultId=100003&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab
This same failure is on the 7.0.RC1 dependency flow as well. https://github.com/dotnet/sdk/pull/27210
There are some binlogs in the artifacts, not sure if those would help?
https://dev.azure.com/dnceng/public/_build/results?buildId=1946548&view=artifacts&pathAsName=false&type=publishedArtifacts
Who is the author of the tests? If it is the sdk, then please ask dotnet/domestic-cat for assistance.
It looks like a crossgen check is running when targeting blazor-wasm and understandably fails to find a suitable runtime, could https://github.com/dotnet/sdk/pull/27159 have anything to do with it?