Jed Lejosne
Jed Lejosne
Looks good at first glance, let's see how testing goes! /ok-to-test
/cc @vladikr Please have a look, I'm not 100% confident about my description for some of the migration options...
Thank you for the review!! > 1. I think that having defaults in comments can be problematic. Since it's not enforced, there could easily be a case when someone updates...
@xpivarc wow, ok, nice catch (https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8247/pull-kubevirt-e2e-k8s-1.23-sig-compute/1555254648250568704) /hold I'll give that one a bump too then
/hold cancel Added a commit to bump libvirtd as well, PTAL!
> from the design it looks like what I requested. @jean-edouard do you have the bandwidth to do a code review? :+1: thanks, will do!
Document looks good. Just a couple questions: - Why the empty tables at the end? Are they templates? They should probably be under their own `##` section. - What is...
Legit failure: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8159/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1559846596550594560 The test needs to be adjusted for the new disk.