Add support for USB Disks

[acardace]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Add support for USB disks

[acardace]

/retest-required

[rmohr]

Hey @acardace I am curious, what are the use-cases for usb disks?

[acardace]

Hey @acardace I am curious, what are the use-cases for usb disks?

Hi @rmohr, it's pretty much for completeness since you can construct such a VM with plain libvirt or qemu.

Also, it can be useful for os-level debugging or test purposes.

[acardace]

/retest-required

[rmohr]

Hey @acardace I am curious, what are the use-cases for usb disks?

Hi @rmohr, it's pretty much for completeness since you can construct such a VM with plain libvirt or qemu.

Also, it can be useful for os-level debugging or test purposes.

Thanks for the details, I was hoping for some more concrete examples where we saw someone blocked or where adding an usb disk upfront helped debugging somehow. Do you know about some cases?

[acardace]

Hey @acardace I am curious, what are the use-cases for usb disks?

Hi @rmohr, it's pretty much for completeness since you can construct such a VM with plain libvirt or qemu. Also, it can be useful for os-level debugging or test purposes.

Thanks for the details, I was hoping for some more concrete examples where we saw someone blocked or where adding an usb disk upfront helped debugging somehow. Do you know about some cases?

The best example I can think of is debugging a USB device kernel driver or the USB emulation code in qemu.

[rmohr]

/lgtm

lgtm for the code.

Not approving yet. Adding @davidvossel and @vladikr to hear their opinion about this, since we don't seem to have an immediate use-case for this.

[rmohr]

/cc @davidvossel /cc @vladikr

[acardace]

/test pull-kubevirt-e2e-k8s-1.22-sig-compute-migrations

[jean-edouard]

Legit failure: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/8159/pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations/1559846596550594560 The test needs to be adjusted for the new disk.

[acardace]

/retest

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [jean-edouard]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[acardace]

@rmohr can you take another look? I just had to rebase pretty much.

[rmohr]

Seems like no objections to adding usb disk support.

/lgtm

[rmohr]

@rmohr can you take another look? I just had to rebase pretty much.

Will probably compete with #7007. Let's see who wins the race :)

[acardace]

/retest

[kubevirt-bot]

@acardace: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-fossa	2579ebd744423bf73d652916863b2e899d97a6ce	link	false	/test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kubevirt-commenter-bot]

/retest-required This bot automatically retries required jobs that failed/flaked on approved PRs. Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[acardace]

@rmohr can you take another look? I just had to rebase pretty much.

Will probably compete with #7007. Let's see who wins the race :)

Thank you for taking a look, btw won :)