Jed Lejosne
Jed Lejosne
/approve @lyarwood there's a commit marked WIP, probably needs fixing @enp0s3 you might be interested by the couple commits that move logic from the VMI controller to the webhook. It...
> /hold > > While I look into the following failure, not sure if it's related to the changes in this PR at first glance: Status update is currently broken,...
@lyarwood thanks for the rebase! Is the hold still necessary?
/uncc @0xFelix /uncc @lyarwood
> > Since we run 3 threads, each every second, pointlessly reenqueuing all migrations takes a total of around 300 seconds. > > Can you elaborate on the "each every...
> > ```go > > go wait.Until(c.runWorker > > ``` > > That piece of code means if the worker ever exits (it should not happen), then it will be...
> > > ```go > > > go wait.Until(c.runWorker > > > ``` > > > > > > That piece of code means if the worker ever exits (it...
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations
/hold While this fixes the starvation of running migrations, it doesn't address the fact that the migration controller keeps looping on pending keys to re-enqueue them. I'll be investigating an...