Josh Matthews

When I have a `recv: IpcReceiver`, writing code like this feels like boilerplate: ```rust ROUTER.add_route( recv.to_opaque(), Box::new(move |msg| { do_something( msg.to() .expect("deserialization failed"), ); }), ); ``` I would rather...

Sending a sender over a channel and immediately receiving from the corresonding receiver intermittently fails on linux

2

https://github.com/servo/ipc-channel/pull/179 This is one of our longest-existing and most distributed intermittent failures in Servo's automated tests.

Unix channels trigger valgrind errors

1

One example from https://paste.sh/LwlXNbkD#GFVUcztjTpQbNpZoVKg4SDmI: ``` ==130127== Thread 57 LayoutThread Pip: ==130127== Syscall param sendmsg(msg.msg_control) points to uninitialised byte(s) ==130127== at 0xE7E83A7: __libc_sendmsg (sendmsg.c:28) ==130127== by 0xE7E83A7: sendmsg (sendmsg.c:25) ==130127== by...

From a Servo test run: ``` ▶ TIMEOUT [expected OK] /_mozilla/webgl/conformance-1.0.3/conformance/ogles/GL/log2/log2_009_to_012.html │ │ VMware, Inc. │ softpipe │ 3.3 (Core Profile) Mesa 18.1.0-devel │ DESCRIPTION: WebGL GLSL conformance test: log2_009_to_012.html...

``` thread 'ScriptTask PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(0) }' panicked at 'assertion failed: mach_sys::mach_port_mod_refs(mach_task_self(), self.port, MACH_PORT_RIGHT_SEND, 1) == KERN_SUCCESS', /Users/jdm/.cargo/git/checkouts/ipc-channel-d95a23d1f1577bfc/master/platform/macos/mod.rs:292 * thread #6: tid = 0x26ded7, 0x000000010297fe90 servo`rust_panic, stop...

Force clang to treat all input files as C++.

3

Fixes #38. sccache guesses what mode to run the compiler in based on the filename, which makes clang complain when we pass C++ flags when building C files. Forcing C++...

Can't build with new versions of cc-rs when using sccache

2

Linux builds break with this error: ``` running: "sccache" "clang++" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "--target=x86_64-unknown-linux-gnu" "-I" "gfx/angle/checkout/include/" "-I" "gfx/angle/checkout/out/gen/angle/" "-I" "gfx/angle/checkout/src/" "-I" "gfx/angle/checkout/src/common/third_party/base/" "-std=c++14" "-msse2" "-DANGLE_ENABLE_DEBUG_ANNOTATIONS" "-DANGLE_ENABLE_ESSL" "-DANGLE_ENABLE_GLSL"...

Compare shader validation options against gecko's choices

1

https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/dom/canvas/WebGLShaderValidator.cpp#31 There are some differences that we probably want to copy.

The presence of a Rust crate that calls C functions that are compiled into in the ANGLE static library makes it hard to deal with the DLL mess that exists...

Based on https://stackoverflow.com/questions/2384932/converting-static-link-library-to-dynamic-dll, we should be able to avoid building all of the source files twice when building a static library as well as a DLL. Given the overlap between...