Josh Matthews

We don't run highfive on rust-mozjs yet, but this is one of those dangerous constructs that it would be nice to warn about.

Saying "please consider add a reftest" is useless if the PR author has no idea what a reftest is.

The first time the label is added, we should check for the presence of common issues. I need to think about what this involves, but off the top of my...

When travis completes successfully, add an r+ comment if there's a label present

2

This would enable a "merge if this compiles" workflow which allows reviewers to be more hands-off during the process.

Add S-fails-tidy when appropriate commit status changes

5

`"context": "homu"` and `"state": "failure"` appear to be key.

List submodules being updated by a PR

1

Every time a PR updates and includes a submodule change, we should add a comment to draw attention to that fact.

Look for `unsafe {` and `unsafe fn` instead of just `unsafe`.

It doesn't have to be good or bad, just a quick glance of "oh, this PR sure add a lot of new clone calls." Look at the number of `.clone()`...

``` * thread #43, stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0) frame #0: 0x000000011ba94c29 servo`core::intrinsics::copy_nonoverlapping::h64863016c6ffb52b(src="", dst=0x0000000000000000, count=0) at intrinsics.rs:2125:9 2122 && is_nonoverlapping(src, dst, count)) 2123 { 2124 // Not panicking to...