Josh Matthews

Video element with base64 encoded data URL of valid video file contents causes a media error

1

This code breaks tests: https://github.com/servo/servo/blob/main/tests/wpt/tests/html/canvas/element/manual/imagebitmap/common.sub.js#L56-L78. We get an error from gstreamer that looks like this: ``` 0:03.16 pid:96913 [2024-06-29T16:00:09Z ERROR script::dom::htmlmediaelement] Player error: "Error from element /GstPlayBin:playbin/GstURIDecodeBin:uridecodebin0/GstDecodeBin:decodebin0/avdec_h264:avdec_h264-0: Could not decode...

SAFETY comments should document preconditions

1

Reading through https://github.com/microsoft/Windows-rust-driver-samples/blob/d9cc3091625f2d3eb0d528b3e6e9ab2c0551c372/general/echo/kmdf/exe/src/main.rs#L4, I see unsafe blocks labeled with SAFETY comments, which is great! However, the comments focus on why the unsafe block is required (eg. a specific FFI call...

Ensure parsers initiated from DOMParser always complete.

6

This fixes a panic exposed by https://github.com/servo/servo/pull/32820#discussion_r1713451553. We used to run automated tests with the async tokenizer in the pre-Github CI setup, but that was never ported over. These changes...

Panic in webstorage/symbol-props.window.js ("Not a string-convertible JSID?")

6

To reproduce: `./mach test-wpt tests/wpt/tests/webstorage/symbol-props.window.js` Backtrace: ``` pid:48511 Not a string-convertible JSID? (thread Script(1,1), at /Users/jdm/src/servo/target/debug/build/script-691217678d484feb/out/Bindings/StorageBinding.rs:607) 0:05.45 pid:48511 13: core::option::Option::expect 0:05.45 pid:48511 at /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library/core/src/option.rs:898:21 0:05.49 pid:48511 14: script::dom::bindings::codegen::Bindings::StorageBinding::Storage_Binding::delete::{{closure}}::{{closure}} 0:05.49 pid:48511...

Support HTML parser reentrancy

22

These changes adjust the Servo parser implementations to match the interface changes in https://github.com/servo/html5ever/tree/no-mut-interface. Additionally, we can now remove the assertions around active parsers when invoking arbitrary JS (added in...

Multiprocess isn't tested in CI

1

We used to run a subset of WPT in multiprocess mode in the pre-GitHub CI: https://github.com/nikhilshagri/servo/blob/0750fdc370f766d96933d559e12f3fd566df096d/etc/ci/buildbot_steps.yml#L99 . We should bring that back to help prevent regressions.

Testcase: ```html DOMParser test of how the document's URL is set (no pushstate, no base) { const parser = new DOMParser(); const doc = parser.parseFromString("", "text/html"); } ``` Run with...

Panic in webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html

3

To reproduce: `./mach test-wpt tests/wpt/tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html` Backtrace: ``` pid:47743 Could not start audio render thread: Backend("AudioInfo failed: BoolError { message: \"Failed to build AudioInfo\", filename: \"/Users/jdm/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gstreamer-audio-0.22.6/src/audio_info.rs\", function: \"gstreamer_audio::audio_info::AudioInfoBuilder::build\", line: 77 }")...

Parser should use rooted handles

2

The various parsers in components/script/dom/servoparser/ have `type Handle = Dom`, and there's code that creates rooted nodes and then returns the unrooted Dom values. We should figure out if this...

Extract generated class constructor hook into handwritten functions

22

The output of CGClassConstructHook is [difficult to read](https://github.com/servo/servo/blob/main/components/script/dom/bindings/codegen/CodegenRust.py#L6174-L6217). By following the model of #31569 and creating two generic helper functions that cover both cases (isHTMLConstructor is true/false), it will be...