Josh Matthews

Consider using a pointer offset instead of a slice and integer position

4

The generated assembly for code using next_byte_unchecked like skip_whitespace has a suprising number of indirections in order to actually get the byte value. This is caused by the need to...

I encountered a problem in Servo where we were calling delete_buffer on the result of gen_textures, and the effect was surprisingly subtle. This could be avoided if APIs like delete_buffer...

There is some nontrivial logic duplication happening. It would be nice to extract that into shared helpers that accept GL function pointers to call.

If a review is left with "request changes", we should be able to remove labels and apply new ones.

We should add some logging to figure out whether it's github API-related or failure to parse the logs or something else.

Buildbot log fetching doesn't work for --always-succeed jobs

2

https://github.com/servo/highfive/blob/master/handlers/homu_status/__init__.py#L27-L37 looks for a buildbot job that fails, then finds the stdio log for the failed job and prints that. For jobs like the bluetooth tests that fail if a...

This will make it possible to run as part of the servo infrastructure, rather than on my personal web host.

This will make finding out the status of taskcluster jobs much easier, even compared to the current buildbot setup.

https://github.com/servo/highfive/blob/master/handlers/homu_status/__init__.py#L28-L37 looks for the step marked as failed and grabs the stdout for it. However, since the introduction of `./mach filter-intermittents` and `--no-fail` for `test-wpt`, highfive is now grabbing the...